[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241015074043.GB24501@lst.de>
Date: Tue, 15 Oct 2024 09:40:43 +0200
From: Christoph Hellwig <hch@....de>
To: Jiri Slaby <jirislaby@...nel.org>
Cc: Christoph Hellwig <hch@....de>, stefani@...bold.net,
jassisinghbrar@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kfifo: don't include dma-mapping.h in kfifo.h
On Tue, Oct 15, 2024 at 09:38:24AM +0200, Jiri Slaby wrote:
> On 14. 10. 24, 16:46, Christoph Hellwig wrote:
>> Nothing in kfifo.h needs dma-mapping.h. Drop the include to
>> reduce include bloat.
>
> Except DMA_MAPPING_ERROR.
DMA_MAPPING_ERROR is never used by kfifo.h itself. It is used
by user of the header that instanciate one of the macros that use
it.
> The header should stay self-contained.
It does with this patch. You can include it as the only header
in a source file and will work fine. I've actually tried that.
>
> --
> js
> suse labs
---end quoted text---
Powered by blists - more mailing lists