linux-kernel - Re: [PATCH] wifi: ipw2x00/lib80211: select ARC4 helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5c6a210cb6b83c7523b0e86b306a7cfa7e573fd.camel@sipsolutions.net>
Date: Tue, 15 Oct 2024 09:45:55 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Arnd Bergmann <arnd@...nel.org>, Stanislav Yakovlev
	 <stas.yakovlev@...il.com>, Kalle Valo <kvalo@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, linux-wireless@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: ipw2x00/lib80211: select ARC4 helper

On Tue, 2024-10-15 at 07:32 +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The lib80211 code uses arc4 crypto helpers that can be
> disabled:
> 
> ERROR: modpost: "arc4_setkey" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
> ERROR: modpost: "arc4_crypt" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
> 
> Select the library from Kconfig to ensure this can be called.
> 
> Fixes: 02f220b52670 ("wifi: ipw2x00/lib80211: move remaining lib80211 into libipw")

Right, sorry. I sent a similar one before:

https://lore.kernel.org/linux-wireless/20241011115820.070c468b271d.Iac76e81b5cd9a5b949b8c154381128e8131d581d@changeid/

> +++ b/drivers/net/wireless/intel/ipw2x00/Kconfig
> @@ -6,6 +6,7 @@
>  config IPW2100
>  	tristate "Intel PRO/Wireless 2100 Network Connection"
>  	depends on PCI && CFG80211
> +	select CRYPTO_LIB_ARC4
> 
I think this got to the wrong place?

johannes