[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241015075053.GA25249@lst.de>
Date: Tue, 15 Oct 2024 09:50:53 +0200
From: Christoph Hellwig <hch@....de>
To: Jiri Slaby <jirislaby@...nel.org>
Cc: Christoph Hellwig <hch@....de>, stefani@...bold.net,
jassisinghbrar@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kfifo: don't include dma-mapping.h in kfifo.h
On Tue, Oct 15, 2024 at 09:47:31AM +0200, Jiri Slaby wrote:
>> diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
>> index 6797770474a55d..680243751d625f 100644
>> --- a/drivers/mailbox/omap-mailbox.c
>> +++ b/drivers/mailbox/omap-mailbox.c
>> @@ -15,6 +15,7 @@
>> #include <linux/slab.h>
>> #include <linux/kfifo.h>
>> #include <linux/err.h>
>> +#include <linux/io.h>
>
> Oh, I've just noticed this. Why io.h?
Because it would not comple with out it. To be specific: asm/io.h is
where __raw_readl and __raw_writel are defined, and we generally prefer
the Linux over the asm headers.
>
> --
> js
> suse labs
---end quoted text---
Powered by blists - more mailing lists