linux-kernel - Re: [PATCH -next] selftests/cgroup: Fix compile error in test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zw3AE90cH8g8Blx4@slm.duckdns.org>
Date: Mon, 14 Oct 2024 15:06:27 -1000
From: Tejun Heo <tj@...nel.org>
To: Xiu Jianfeng <xiujianfeng@...weicloud.com>
Cc: lizefan.x@...edance.com, hannes@...xchg.org, mkoutny@...e.com,
	shuah@...nel.org, joshua.hahn6@...il.com, cgroups@...r.kernel.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	xiujianfeng@...wei.com
Subject: Re: [PATCH -next] selftests/cgroup: Fix compile error in test_cpu.c

On Fri, Oct 11, 2024 at 06:11:53AM +0000, Xiu Jianfeng wrote:
> From: Xiu Jianfeng <xiujianfeng@...wei.com>
> 
> When compiling the cgroup selftests with the following command:
> 
> make -C tools/testing/selftests/cgroup/
> 
> the compiler complains as below:
> 
> test_cpu.c: In function ‘test_cpucg_nice’:
> test_cpu.c:284:39: error: incompatible type for argument 2 of ‘hog_cpus_timed’
>   284 |                 hog_cpus_timed(cpucg, param);
>       |                                       ^~~~~
>       |                                       |
>       |                                       struct cpu_hog_func_param
> test_cpu.c:132:53: note: expected ‘void *’ but argument is of type ‘struct cpu_hog_func_param’
>   132 | static int hog_cpus_timed(const char *cgroup, void *arg)
>       |                                               ~~~~~~^~~
> 
> Fix it by passing the address of param to hog_cpus_timed().
> 
> Fixes: 2e82c0d4562a ("cgroup/rstat: Selftests for niced CPU statistics")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>

Applied to cgroup/for-6.13.

Thanks.

-- 
tejun