[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANn89iJdmrOEYy3sH2A-1rBE8sVyDJq2yx3jVy1GmKoeqr8cTw@mail.gmail.com>
Date: Tue, 15 Oct 2024 10:06:30 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: ignat@...udflare.com, alex.aring@...il.com, alibuda@...ux.alibaba.com,
davem@...emloft.net, dsahern@...nel.org, johan.hedberg@...il.com,
kernel-team@...udflare.com, kuba@...nel.org, linux-bluetooth@...r.kernel.org,
linux-can@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-wpan@...r.kernel.org, luiz.dentz@...il.com, marcel@...tmann.org,
miquel.raynal@...tlin.com, mkl@...gutronix.de, netdev@...r.kernel.org,
pabeni@...hat.com, socketcan@...tkopp.net, stefan@...enfreihafen.org,
willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next v3 8/9] net: warn, if pf->create does not clear
sock->sk on error
On Mon, Oct 14, 2024 at 11:40 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> From: Ignat Korchagin <ignat@...udflare.com>
> Date: Mon, 14 Oct 2024 16:38:07 +0100
> > All pf->create implementations have been fixed now to clear sock->sk on
> > error, when they deallocate the allocated sk object.
> >
> > Put a warning in place to make sure we don't break this promise in the
> > future.
> >
> > Suggested-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> > Signed-off-by: Ignat Korchagin <ignat@...udflare.com>
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>
Reviewed-by: Eric Dumazet <edumazet@...gle.com>
Powered by blists - more mailing lists