linux-kernel - Re: [PATCH v2 0/4] Add support for APPS SMMU on QCS615

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0bd108f-1133-473a-a0e5-6efe1b19f50d@kernel.org>
Date: Tue, 15 Oct 2024 10:20:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Qingqing Zhou <quic_qqzhou@...cinc.com>, andersson@...nel.org,
 konradybcio@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, robimarko@...il.com, will@...nel.org,
 robin.murphy@....com, joro@...tes.org
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, iommu@...ts.linux.dev
Subject: Re: [PATCH v2 0/4] Add support for APPS SMMU on QCS615

On 15/10/2024 10:15, Qingqing Zhou wrote:
> Enable APPS SMMU function on QCS615 platform. APPS SMMU is required
> for address translation in devices including Ethernet/UFS/USB and
> so on.
> 
> Add the SCM node for SMMU probing normally. SMMU driver probe will
> check qcom_scm ready or not, without SCM node, SMMU driver probe will
> defer.
> The dmesg log without SCM node:
> platform 15000000.iommu: deferred probe pending: arm-smmu: qcom_scm not ready
> 
> With the SCM node, SMMU can probe normally, but SCM driver still fails
> to probe because of one SCM bug:
> qcom_scm firmware:scm: error (____ptrval____): Failed to enable the TrustZone memory allocator
> qcom_scm firmware:scm: probe with driver qcom_scm failed with error 4
> The above SCM bug is fixed by:
> https://lore.kernel.org/all/20241005140150.4109700-2-quic_kuldsing@quicinc.com/
> But above patch doesn't impact building of current patch series, this patch
> series can build successfully without above patch.
> 
> Dependency:
> https://lore.kernel.org/all/20240926-add_initial_support_for_qcs615-v3-0-e37617e91c62@quicinc.com/
> 
> Changes in v2:
> - Address the comments on bindings from Krzysztof.

Which comments? Be specific what changed.

Best regards,
Krzysztof