linux-kernel - Re: [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241015083603.GB8348@google.com>
Date: Tue, 15 Oct 2024 09:36:03 +0100
From: Lee Jones <lee@...nel.org>
To: Karel Balej <balejk@...fyz.cz>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>,
	linux-kernel@...r.kernel.org, linux-rtc@...r.kernel.org,
	duje.mihanovic@...le.hr, phone-devel@...r.kernel.org,
	~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

On Sat, 12 Oct 2024, Karel Balej wrote:

> Add a MFD cell for the chip's real-time clock.
> 
> Signed-off-by: Karel Balej <balejk@...fyz.cz>
> ---
> 
> Notes:
>     RFC v2:
>     - Break out the register definitions and reword the commit message
>       accordingly.
>     - RFC v1: https://lore.kernel.org/r/20240920161518.32346-1-balejk@matfyz.cz/
> 
>  drivers/mfd/88pm886.c | 1 +
>  1 file changed, 1 insertion(+)

Looks fine.  Let me know when you're ready for me to take it.

> diff --git a/drivers/mfd/88pm886.c b/drivers/mfd/88pm886.c
> index dbe9efc027d2..891fdce5d8c1 100644
> --- a/drivers/mfd/88pm886.c
> +++ b/drivers/mfd/88pm886.c
> @@ -37,6 +37,7 @@ static struct resource pm886_onkey_resources[] = {
>  static struct mfd_cell pm886_devs[] = {
>  	MFD_CELL_RES("88pm886-onkey", pm886_onkey_resources),
>  	MFD_CELL_NAME("88pm886-regulator"),
> +	MFD_CELL_NAME("88pm886-rtc"),
>  };
>  
>  static int pm886_power_off_handler(struct sys_off_data *sys_off_data)
> -- 
> 2.47.0
> 

-- 
Lee Jones [李琼斯]