linux-kernel - Re: [PATCH v4 4/9] misc: amd-sbi: Add support for AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <38ae8fae-cbb7-dab5-c7ae-fc029dfef6a6@amd.com>
Date: Tue, 15 Oct 2024 14:34:23 +0530
From: "Gupta, Akshay" <Akshay.Gupta@....com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux@...ck-us.net, arnd@...db.de, naveenkrishna.chatradhi@....com
Subject: Re: [PATCH v4 4/9] misc: amd-sbi: Add support for AMD_SBI IOCTL


On 10/13/2024 8:52 PM, Greg KH wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Thu, Sep 12, 2024 at 07:08:05AM +0000, Akshay Gupta wrote:
>> +     switch (msg.cmd) {
>> +     case 0 ... 0x999:
>> +             /* Mailbox protocol */
>> +             ret = rmi_mailbox_xfer(data, &msg);
>> +             break;
>> +     default:
>> +             pr_err("Command:0x%x not recognized\n", msg.cmd);
> You now just allowed userspace to spam the kernel logs for no good
> reason :(
Thanks, will remove the pr_err to not to spam the logs.
>
> Also, always use dev_*() calls in a driver, not pr_*() ones, as then you
> will know exactly what driver/device is sending out the message.
Thank you for the input, will do.
>
>> +             break;
> And you returned the wrong error code if this happens :(
>
> greg k-h
my bad, will take care of this.