linux-kernel - Re: [PATCH] resource: Remove dependency on SPARSEMEM from GET_FREE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3450df1e-dcb2-495a-8fe4-0a6e096429fd@redhat.com>
Date: Tue, 15 Oct 2024 12:33:24 +0200
From: David Hildenbrand <david@...hat.com>
To: "Huang, Ying" <ying.huang@...el.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
 Nathan Chancellor <nathan@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 Dan Williams <dan.j.williams@...el.com>,
 Jonathan Cameron <jonathan.cameron@...wei.com>
Subject: Re: [PATCH] resource: Remove dependency on SPARSEMEM from
 GET_FREE_REGION

On 15.10.24 10:03, Huang, Ying wrote:
> Hi, David,
> 
> David Hildenbrand <david@...hat.com> writes:
> 
>> On 15.10.24 07:15, Huang Ying wrote:
>>> We want to use the functions configured via GET_FREE_REGION in
>>> resource kunit tests.  However, GET_FREE_REGION depends on SPARSEMEM.
>>> This makes resource kunit tests cannot be built on some architectures
>>> lacking SPARSEMEM.  In fact, these functions doesn't depend on
>>> SPARSEMEM now.  So, remove dependency on SPARSEMEM from
>>> GET_FREE_REGION.
>>> Link:
>>> https://lore.kernel.org/lkml/20240922225041.603186-1-linux@roeck-us.net/
>>> Signed-off-by: "Huang, Ying" <ying.huang@...el.com>
>>> Tested-by: Guenter Roeck <linux@...ck-us.net>
>>> Cc: Nathan Chancellor <nathan@...nel.org>
>>> Cc: Arnd Bergmann <arnd@...db.de>
>>> Cc: Dan Williams <dan.j.williams@...el.com>
>>> Cc: David Hildenbrand <david@...hat.com>
>>> Cc: Jonathan Cameron <jonathan.cameron@...wei.com>
>>> ---
>>>    mm/Kconfig | 1 -
>>>    1 file changed, 1 deletion(-)
>>> diff --git a/mm/Kconfig b/mm/Kconfig
>>> index 4c9f5ea13271..33fa51d608dc 100644
>>> --- a/mm/Kconfig
>>> +++ b/mm/Kconfig
>>> @@ -1085,7 +1085,6 @@ config HMM_MIRROR
>>>    	depends on MMU
>>>      config GET_FREE_REGION
>>> -	depends on SPARSEMEM
>>>    	bool
>>>      config DEVICE_PRIVATE
>>
>> Added by
>>
>> commit 14b80582c43e4f550acfd93c2b2cadbe36ea0874
>> Author: Dan Williams <dan.j.williams@...el.com>
>> Date:   Fri May 20 13:41:24 2022 -0700
>>
>>      resource: Introduce alloc_free_mem_region()
>>
>> @Dan, any insight why that dependency was added?
> 
> Dan has explain it some what in the following email,
> 
> https://lore.kernel.org/lkml/66f5abd431dce_964f2294b9@dwillia2-xfh.jf.intel.com.notmuch/
> 
> This is reachable from the "Link:" tag in the patch.

That should be part of the patch description then :)

-- 
Cheers,

David / dhildenb