linux-kernel - Re: [PATCH v4 08/28] media: iris: implement power management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410151929.iJzD1Wez-lkp@intel.com>
Date: Tue, 15 Oct 2024 19:25:56 +0800
From: kernel test robot <lkp@...el.com>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>,
	Vikash Garodia <quic_vgarodia@...cinc.com>,
	Abhinav Kumar <quic_abhinavk@...cinc.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>
Cc: oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
	Hans Verkuil <hverkuil@...all.nl>,
	Sebastian Fricke <sebastian.fricke@...labora.com>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Dikshita Agarwal <quic_dikshita@...cinc.com>
Subject: Re: [PATCH v4 08/28] media: iris: implement power management

Hi Dikshita,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 67cefecf2a039b9ed0030b9213ceafcd45e6f9e3]

url:    https://github.com/intel-lab-lkp/linux/commits/Dikshita-Agarwal/dt-bindings-media-Add-video-support-for-QCOM-SM8550-SoC/20241014-171950
base:   67cefecf2a039b9ed0030b9213ceafcd45e6f9e3
patch link:    https://lore.kernel.org/r/20241014-qcom-video-iris-v4-v4-8-c5eaa4e9ab9e%40quicinc.com
patch subject: [PATCH v4 08/28] media: iris: implement power management
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241015/202410151929.iJzD1Wez-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241015/202410151929.iJzD1Wez-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410151929.iJzD1Wez-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/media/platform/qcom/iris/iris_probe.c:292:12: warning: 'iris_pm_resume' defined but not used [-Wunused-function]
     292 | static int iris_pm_resume(struct device *dev)
         |            ^~~~~~~~~~~~~~
>> drivers/media/platform/qcom/iris/iris_probe.c:273:12: warning: 'iris_pm_suspend' defined but not used [-Wunused-function]
     273 | static int iris_pm_suspend(struct device *dev)
         |            ^~~~~~~~~~~~~~~


vim +/iris_pm_resume +292 drivers/media/platform/qcom/iris/iris_probe.c

   272	
 > 273	static int iris_pm_suspend(struct device *dev)
   274	{
   275		struct iris_core *core;
   276		int ret;
   277	
   278		core = dev_get_drvdata(dev);
   279	
   280		mutex_lock(&core->lock);
   281		if (core->state != IRIS_CORE_INIT)
   282			goto exit;
   283	
   284		ret = iris_hfi_pm_suspend(core);
   285	
   286	exit:
   287		mutex_unlock(&core->lock);
   288	
   289		return ret;
   290	}
   291	
 > 292	static int iris_pm_resume(struct device *dev)
   293	{
   294		struct iris_core *core;
   295		int ret = 0;
   296	
   297		core = dev_get_drvdata(dev);
   298	
   299		mutex_lock(&core->lock);
   300		if (core->state != IRIS_CORE_INIT)
   301			goto exit;
   302	
   303		ret = iris_hfi_pm_resume(core);
   304		pm_runtime_mark_last_busy(core->dev);
   305	
   306	exit:
   307		mutex_unlock(&core->lock);
   308	
   309		return ret;
   310	}
   311	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki