linux-kernel - Re: [PATCH 2/2] 8250_core.c : Global variable shouldn't be initialized to NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zw5TSaN9BGyNwrsT@smile.fi.intel.com>
Date: Tue, 15 Oct 2024 14:34:33 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Omer Faruk BULUT <m.omerfarukbulut@...il.com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, pmladek@...e.com,
	paulmck@...nel.org, john.ogness@...utronix.de, tony@...mide.com,
	arnd@...db.de, u.kleine-koenig@...gutronix.de,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH 2/2] 8250_core.c : Global variable shouldn't be
 initialized to NULL

On Mon, Oct 14, 2024 at 09:04:15PM +0300, Omer Faruk BULUT wrote:
> I check it with checkpatch. Then remove the NULL part.

checkpatch may be false positive. Please, add a better analysis
that it's fine to do a such cleanup. Note, this variable is _not_
static.

...

> -const struct uart_ops *univ8250_port_base_ops = NULL;
> +const struct uart_ops *univ8250_port_base_ops;

Is it guaranteed to be NULL for non-static variables? If so,
we want to know the details.

>  struct uart_ops univ8250_port_ops;

-- 
With Best Regards,
Andy Shevchenko