linux-kernel - Re: [PATCH V12 net-next 07/10] net: hibmcge: Implement rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25f04101-d92a-466e-9824-098e7c723188@huawei.com>
Date: Tue, 15 Oct 2024 20:05:30 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Paolo Abeni <pabeni@...hat.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>
CC: <shaojijie@...wei.com>, <shenjian15@...wei.com>,
	<wangpeiyang1@...wei.com>, <liuyonglong@...wei.com>, <chenhao418@...wei.com>,
	<sudongming1@...wei.com>, <xujunsheng@...wei.com>, <shiyongbang@...wei.com>,
	<libaihan@...wei.com>, <andrew@...n.ch>, <jdamato@...tly.com>,
	<horms@...nel.org>, <kalesh-anakkur.purayil@...adcom.com>,
	<christophe.jaillet@...adoo.fr>, <jonathan.cameron@...wei.com>,
	<shameerali.kolothum.thodi@...wei.com>, <salil.mehta@...wei.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V12 net-next 07/10] net: hibmcge: Implement rx_poll
 function to receive packets


on 2024/10/15 19:57, Paolo Abeni wrote:
> On 10/15/24 13:41, Jijie Shao wrote:
>> on 2024/10/15 18:28, Paolo Abeni wrote:
>>> Side note: the above always uses the maximum MTU for the packet size,
>>> if the device supports jumbo frames (8Kb size packets), it will
>>> produce quite bad layout for the incoming packets... Is the device
>>> able to use multiple buffers for the incoming packets?
>>
>> In fact, jumbo frames are not supported in device, and the maximum 
>> MTU is 4Kb.
>
> FTR, even 4Kb is bad enough: tiny packets (tcp syn, UDP dns req) will 
> use a truesize above 5K. You can get a much better the layout using 
> copybreak.
>
> Cheers,
>
> Paolo

Sorry, Actually 4KB。the default mtu is 1500