linux-kernel - Re: [PATCH 0/2] net: ethernet: freescale: Use %pa to format resource_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241015121047.GE569285@kernel.org>
Date: Tue, 15 Oct 2024 13:10:47 +0100
From: Simon Horman <horms@...nel.org>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Pantelis Antoniou <pantelis.antoniou@...il.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 0/2] net: ethernet: freescale: Use %pa to format
 resource_size_t

On Tue, Oct 15, 2024 at 07:24:48AM +0000, Daniel Machon wrote:
> > Hi,
> > 
> > This short series addersses the formatting of variables of
> > type resource_size_t in freescale drivers.
> > 
> > The correct format string for resource_size_t is %pa which
> > acts on the address of the variable to be formatted [1].
> > 
> > [1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229
> > 
> > These problems were introduced by
> > commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string")
> > 
> > Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > Closes: https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cce99@linux-m68k.org/
> > 
> > ---
> > Simon Horman (2):
> >       net: fec_mpc52xx_phy: Use %pa to format resource_size_t
> >       net: ethernet: fs_enet: Use %pa to format resource_size_t
> > 
> >  drivers/net/ethernet/freescale/fec_mpc52xx_phy.c     | 2 +-
> >  drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > base-commit: 6aac56631831e1386b6edd3c583c8afb2abfd267
> > 
> 
> Hi Simon,
> 
> Is this for net-next? I dont see a target tree name :-)

Hi Daniel,

Yes, it is. Sorry for forgetting to include that in the subject.

> Looking at the docs, %pa seems correct to me.
> 
> For the series:
> 
> Reviewed-by: Daniel Machon <daniel.machon@...rochip.com>
>