linux-kernel - Re: [PATCH v5 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26514aa5-c835-41d4-b0bc-862f3181cb8c@kernel.org>
Date: Wed, 16 Oct 2024 14:03:54 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Haylen Chu <heylenay@....org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
 Lukasz Luba <lukasz.luba@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen Wang <unicorn_wang@...look.com>,
 Inochi Amaoto <inochiama@...look.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Jisheng Zhang <jszhang@...nel.org>, linux-pm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v5 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add
 Sophgo CV1800 thermal

On 16/10/2024 13:53, Haylen Chu wrote:
>>>>> +
>>>>> +properties:
>>>>> +  compatible:
>>>>> +    enum:
>>>>> +      - sophgo,cv1800-thermal
>>>>
>>>> Not much improved, judging by other patches there is no "CV1800" SoC,
>>>> but that's a family name.  Otherwise please point us to bindings or DTS
>>>> using this SoC.
>>>
>>> "cv1800" is referenced in the clock binding[1] and usb binding[2]. I
>>> don't think there are other CV1800 SoC variants. Usage of "CV1800"
>>
>> There are. git grep cv1800
>>
>>> should be specific and unambiguous.
>>
>> And other places have different name.
> 
> Okay, will use cv1800b in the next revision instead. Thanks.

Just to clarify: I assume the name of the SoC is cv1800b.

Best regards,
Krzysztof