linux-kernel - Re: [PATCH v9 3/8] block: Add bdev atomic write limits helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e56a3443-6195-4171-8c22-b78450f0ba26@oracle.com>
Date: Wed, 16 Oct 2024 13:36:40 +0100
From: John Garry <john.g.garry@...cle.com>
To: Christoph Hellwig <hch@....de>
Cc: axboe@...nel.dk, brauner@...nel.org, djwong@...nel.org,
        viro@...iv.linux.org.uk, jack@...e.cz, dchinner@...hat.com,
        cem@...nel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, hare@...e.de,
        martin.petersen@...cle.com, catherine.hoang@...cle.com,
        mcgrof@...nel.org, ritesh.list@...il.com, ojaswin@...ux.ibm.com
Subject: Re: [PATCH v9 3/8] block: Add bdev atomic write limits helpers

On 16/10/2024 13:29, Christoph Hellwig wrote:
> On Wed, Oct 16, 2024 at 10:03:20AM +0000, John Garry wrote:
>> +static inline unsigned int
>> +bdev_atomic_write_unit_min_bytes(struct block_device *bdev)
>> +{
>> +	if (!bdev_can_atomic_write(bdev))
>> +		return 0;
> 
> Aren't the limits always zero when the block device doesn't support
> atomic writes and we can skip these checks?

Not necessarily. bdev_can_atomic_write() has the partition alignment 
checks also.

> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> 

thanks, but let me know if you would still like to see any changes.