linux-kernel - RE: [PATCH][next] crypto: tegra: remove redundant error check on ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH7PR12MB817831120ABC8F0C44DCAD7BC0462@PH7PR12MB8178.namprd12.prod.outlook.com>
Date: Wed, 16 Oct 2024 12:50:36 +0000
From: Akhil R <akhilrajeev@...dia.com>
To: Colin Ian King <colin.i.king@...il.com>, Herbert Xu
	<herbert@...dor.apana.org.au>, "David S . Miller" <davem@...emloft.net>,
	Thierry Reding <thierry.reding@...il.com>, Jon Hunter <jonathanh@...dia.com>,
	"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
CC: "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH][next] crypto: tegra: remove redundant error check on ret

> Currently there is an unnecessary error check on ret without a proceeding
> assignment to ret that needs checking. The check is redundant and can be
> removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/crypto/tegra/tegra-se-aes.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/crypto/tegra/tegra-se-aes.c b/drivers/crypto/tegra/tegra-se-
> aes.c
> index ae7a0f8435fc..9d130592cc0a 100644
> --- a/drivers/crypto/tegra/tegra-se-aes.c
> +++ b/drivers/crypto/tegra/tegra-se-aes.c
> @@ -1180,8 +1180,6 @@ static int tegra_ccm_do_one_req(struct crypto_engine
> *engine, void *areq)
>                         goto out;
>         } else {
>                 rctx->cryptlen = req->cryptlen - ctx->authsize;
> -               if (ret)
> -                       goto out;
> 
>                 /* CTR operation */
>                 ret = tegra_ccm_do_ctr(ctx, rctx);
> --

Agreed. Thanks for pointing.

Acked-by: Akhil R <akhilrajeev@...dia.com>

Regards,
Akhil