linux-kernel - Re: [PATCH v1 1/1] HID: debug: Remove duplicates from 'keys'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zw_BSeDEZpTQTf6J@smile.fi.intel.com>
Date: Wed, 16 Oct 2024 16:36:09 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: Thomas Kuehne <thomas.kuehne@....li>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	Benjamin Tissoires <bentiss@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] HID: debug: Remove duplicates from 'keys'

On Tue, Oct 15, 2024 at 02:20:19PM +0200, Jiri Kosina wrote:
> On Thu, 5 Sep 2024, Andy Shevchenko wrote:

...

> > drivers/hid/hid-debug.c:3443:18: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> >  3443 |         [KEY_HANGEUL] = "HanGeul",              [KEY_HANGUP_PHONE] = "HangUpPhone",
> >       |                         ^~~~~~~~~
> > drivers/hid/hid-debug.c:3217:18: note: previous initialization is here
> >  3217 |         [KEY_HANGUEL] = "Hangeul",              [KEY_HANJA] = "Hanja",
> >       |                         ^~~~~~~~~
> > 
> > Fix this by removing them.
> > 
> > The logic of removal is that, remove...
> > 1) if there is a constant that uses another defined constant, OR
> > 2) the one that appears later in the list.

...

> > -	[KEY_HANGUEL] = "Hangeul",		[KEY_HANJA] = "Hanja",
> 
> The problem specifically with this one is really there to fix a typo 
> someone did at some point in the past. See b9ab58dd8e771d ("Input: fix 
> misspelling of Hangeul key").
> 
> So I think we should preserve it somehow.

Right, I fixed that in v2 that has been just sent out.

-- 
With Best Regards,
Andy Shevchenko