linux-kernel - Re: [PATCH v3 2/2] irqchip: Kconfig: Added module build support for the TI interrupt aggregator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c2ae869-d04f-481d-b770-ec54f4d2e658@ti.com>
Date: Wed, 16 Oct 2024 08:48:02 -0500
From: Andrew Davis <afd@...com>
To: Guillaume La Roque <glaroque@...libre.com>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Thomas Gleixner
	<tglx@...utronix.de>,
        Nishanth Menon <nm@...com>, Tero Kristo
	<kristo@...nel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>
CC: <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <vishalm@...com>, Mattijs Korpershoek <mkorpershoek@...libre.com>,
        Kevin
 Hilman <khilman@...libre.com>,
        Nicolas Frayer <nfrayer@...libre.com>
Subject: Re: [PATCH v3 2/2] irqchip: Kconfig: Added module build support for
 the TI interrupt aggregator

On 10/16/24 4:41 AM, Guillaume La Roque wrote:
> From: Nicolas Frayer <nfrayer@...libre.com>
> 
> Added module build support in Kconfig for the TI SCI interrupt aggregator
> driver. The driver's default build is built-in and it also depends on
> ARCH_K3 as the driver uses some 64 bit ops and should only be built
> for 64 bit platforms.
> 
> Signed-off-by: Nicolas Frayer <nfrayer@...libre.com>
> Signed-off-by: Guillaume La Roque <glaroque@...libre.com>
> ---
>   arch/arm64/Kconfig.platforms      | 1 -
>   drivers/irqchip/Kconfig           | 5 +++--
>   drivers/irqchip/irq-ti-sci-inta.c | 1 +
>   3 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 393845a3ae5c..9dea47decfbd 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -135,7 +135,6 @@ config ARCH_K3
>   	select SOC_TI
>   	select TI_MESSAGE_MANAGER
>   	select TI_SCI_PROTOCOL
> -	select TI_SCI_INTA_IRQCHIP
>   	select TI_K3_SOCINFO
>   	help
>   	  This enables support for Texas Instruments' K3 multicore SoC
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index a958731404e9..9646322345e4 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -544,10 +544,11 @@ config TI_SCI_INTR_IRQCHIP
>   	  TI System Controller, say Y here. Otherwise, say N.
>   
>   config TI_SCI_INTA_IRQCHIP
> -	bool
> -	depends on TI_SCI_PROTOCOL
> +	tristate "TI SCI INTA Interrupt Controller"
> +	depends on ARCH_K3 && TI_SCI_PROTOCOL

You can still compile test, just gate it on 64BIT (or ARM64 if those
64bit ops are only available on ARM64).

depends on ARCH_K3 || (COMPILE_TEST && ARM64)

BTW, the last time this was posted the feedback was that if this
was compiled as a module we might have issues with dependent drivers
not having this IRQ ready as it may be loaded later. I think this
would only cause probe defers if the drivers are well behaving, but
something to double check.

Andrew

>   	select IRQ_DOMAIN_HIERARCHY
>   	select TI_SCI_INTA_MSI_DOMAIN
> +	default ARCH_K3
>   	help
>   	  This enables the irqchip driver support for K3 Interrupt aggregator
>   	  over TI System Control Interface available on some new TI's SoCs.
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index b83f5cbab123..a887efba262c 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -743,3 +743,4 @@ module_platform_driver(ti_sci_inta_irq_domain_driver);
>   
>   MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@...com>");
>   MODULE_DESCRIPTION("K3 Interrupt Aggregator driver over TI SCI protocol");
> +MODULE_LICENSE("GPL");
>