linux-kernel - Re: [PATCH] net: plip: fix break; causing plip to never transmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241016141715.GH2162@kernel.org>
Date: Wed, 16 Oct 2024 15:17:15 +0100
From: Simon Horman <horms@...nel.org>
To: boehm.jakub@...il.com
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev
Subject: Re: [PATCH] net: plip: fix break; causing plip to never transmit

On Tue, Oct 15, 2024 at 05:16:04PM +0200, Jakub Boehm via B4 Relay wrote:
> From: Jakub Boehm <boehm.jakub@...il.com>
> 
> Since commit
>   71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
> 
> plip was not able to send any packets, this patch replaces one
> unintended break; with fallthrough; which was originally missed by
> commit 9525d69a3667 ("net: plip: mark expected switch fall-throughs").
> 
> I have verified with a real hardware PLIP connection that everything
> works once again after applying this patch.
> 
> Fixes: 71ae2cb30531 ("net: plip: Fix fall-through warnings for Clang")
> Signed-off-by: Jakub Boehm <boehm.jakub@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>