linux-kernel - Re: [PATCH] rust: query the compiler for dylib path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATnhdshYWAHyqz9HRjTggj=7SFB_8d2Oqkr4OOupY9Lag@mail.gmail.com>
Date: Wed, 16 Oct 2024 10:35:51 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, Daniel Gomez <da.gomez@...sung.com>, 
	rust-for-linux@...r.kernel.org, Fiona Behrens <me@...enk.dev>, 
	Nathan Chancellor <nathan@...nel.org>, Nicolas Schier <nicolas@...sle.eu>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Boqun Feng <boqun.feng@...il.com>, 
	Gary Guo <gary@...yguo.net>, Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	"David S. Miller" <davem@...emloft.net>, Kris Van Hees <kris.van.hees@...cle.com>, 
	Íñigo Huguet <ihuguet@...hat.com>, 
	Thomas Weißschuh <linux@...ssschuh.net>, 
	Vegard Nossum <vegard.nossum@...cle.com>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, linux-kernel@...r.kernel.org, 
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] rust: query the compiler for dylib path

On Wed, Oct 16, 2024 at 12:53 AM Tamir Duberstein <tamird@...il.com> wrote:
>
> On Tue, Oct 15, 2024 at 11:30 AM Miguel Ojeda
> <miguel.ojeda.sandonis@...il.com> wrote:
> >
> > If a trick still requires a similar amount of changes to mainline,
> > then I think we should go for something better/more proper, i.e. the
> > idea is to minimize changes/complexity upstream, after all.
>
> In that case v5[0] is probably the way to go?
>
> On Mon, Oct 14, 2024 at 2:45 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
> > This no-clean-files is meaningless and unnecessary.
> > This line exists inside the "ifdef CONFIG_RUST" ... "endif" block.
> >
> > no-clean-files is only used by scripts/Makefile.clean,
> > which does not include include/config/auto.conf.
>
> I see. Was it necessary before this patch? Looks like it came with the
> initial rust support patch.


You can just delete no-clean-files from your patch.


Files specified to $(always-y) are removed by "make clean".
That's why [0] added no-clean-files to negate it.


You are moving "always-$(CONFIG_RUST) += libmacros.so"
into the "ifdef CONFIG_RUST" ... "endif" block, which is not
parsed by "make clean".




>
> [0] https://lore.kernel.org/all/20241010142833.98528-2-tamird@gmail.com/



-- 
Best Regards
Masahiro Yamada