linux-kernel - Re: [PATCH] perf test: Speed up some tests using perf list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP-5=fW3So87z8Q+J5eNf+a2PP2toDe3GX5HB7akecR7TBV__A@mail.gmail.com>
Date: Wed, 16 Oct 2024 07:55:17 -0700
From: Ian Rogers <irogers@...gle.com>
To: James Clark <james.clark@...aro.org>
Cc: Namhyung Kim <namhyung@...nel.org>, Arnaldo Carvalho de Melo <acme@...nel.org>, 
	Kan Liang <kan.liang@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Peter Zijlstra <peterz@...radead.org>, 
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>, 
	linux-perf-users@...r.kernel.org, Leo Yan <leo.yan@....com>, 
	German Gomez <german.gomez@....com>, Carsten Haitzler <carsten.haitzler@....com>
Subject: Re: [PATCH] perf test: Speed up some tests using perf list

On Wed, Oct 16, 2024 at 1:25 AM James Clark <james.clark@...aro.org> wrote:
>
>
>
> On 16/10/2024 7:56 am, Namhyung Kim wrote:
> > On my system, perf list is very slow to print the whole events.  I think
> > there's a performance issue in SDT and uprobes event listing.  I noticed
> > this issue while running perf test on x86 but it takes long to check
> > some CoreSight event which should be skipped quickly.
> >
> > Anyway, some test uses perf list to check whether the required event is
> > available before running the test.  The perf list command can take an
> > argument to specify event class or (glob) pattern.  But glob pattern is
> > only to suppress output for unmatched ones after checking all events.
> >
> > In this case, specifying event class is better to reduce the number of
> > events it checks and to avoid buggy subsystems entirely.
> >
> > No functional changes intended.
> >
> > Cc: German Gomez <german.gomez@....com>
> > Cc: Carsten Haitzler <carsten.haitzler@....com>
> > Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> > ---
>
> Reviewed-by: James Clark <james.clark@...aro.org>

Reviewed-by: Ian Rogers <irogers@...gle.com>

There's a nice better than >2x speed up waiting in too :-)
https://lore.kernel.org/lkml/20241011220354.756798-1-irogers@google.com/

Thanks,
Ian