linux-kernel - Re: [PATCH v2 05/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e6a0a70a-e4e3-47f8-ab0a-111697e0822d@amd.com>
Date: Wed, 16 Oct 2024 11:06:49 -0500
From: Mario Limonciello <mario.limonciello@....com>
To: Hans de Goede <hdegoede@...hat.com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Borislav Petkov <bp@...en8.de>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 x86@...nel.org, "Gautham R . Shenoy" <gautham.shenoy@....com>,
 Perry Yuan <perry.yuan@....com>, linux-kernel@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-pm@...r.kernel.org,
 platform-driver-x86@...r.kernel.org,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH v2 05/13] platform/x86: hfi: Introduce AMD Hardware
 Feedback Interface Driver

On 10/16/2024 04:59, Hans de Goede wrote:
> Hi,
> 
> On 16-Oct-24 11:36 AM, Uwe Kleine-König wrote:
>> Hello,
>>
>> On Thu, Oct 10, 2024 at 02:36:57PM -0500, Mario Limonciello wrote:
>>> +static struct platform_driver amd_hfi_driver = {
>>> +	.driver = {
>>> +		.name = AMD_HFI_DRIVER,
>>> +		.owner = THIS_MODULE,
>>> +		.acpi_match_table = ACPI_PTR(amd_hfi_platform_match),
>>> +	},
>>> +	.probe = amd_hfi_probe,
>>> +	.remove_new = amd_hfi_remove,
>>> +};
>>
>> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
>> return void") .remove() is (again) the right callback to implement for
>> platform drivers. Please just drop "_new".
> 
> Note there is a "[v3,05/14] platform/x86: hfi: Introduce AMD Hardware
> Feedback Interface Driver" patch superseding this one now; and that one
> has the same issue.
> 
> Regards,
> 
> Hans
> 

Thanks!  I'll gather more review feedback this week and fix this in a v4 
next week.