linux-kernel - Re: [PATCH v5 11/40] x86/resctrl: Export resctrl fs's init function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zw_n3kpOGuGxRFrX@agluck-desk3.sc.intel.com>
Date: Wed, 16 Oct 2024 09:20:46 -0700
From: Tony Luck <tony.luck@...el.com>
To: James Morse <james.morse@....com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
	Fenghua Yu <fenghua.yu@...el.com>,
	Reinette Chatre <reinette.chatre@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	H Peter Anvin <hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
	shameerali.kolothum.thodi@...wei.com,
	D Scott Phillips OS <scott@...amperecomputing.com>,
	carl@...amperecomputing.com, lcherian@...vell.com,
	bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
	baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
	Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
	dfustini@...libre.com, amitsinght@...vell.com,
	David Hildenbrand <david@...hat.com>,
	Rex Nie <rex.nie@...uarmicro.com>,
	Dave Martin <dave.martin@....com>,
	Shaopeng Tan <tan.shaopeng@...fujitsu.com>
Subject: Re: [PATCH v5 11/40] x86/resctrl: Export resctrl fs's init function

On Fri, Oct 04, 2024 at 06:03:18PM +0000, James Morse wrote:
> rdtgroup_init() needs exporting so that arch code can call it once
                        ^^^^^^^^^
> it lives in core code. As this is one of the few functions exported,
> rename it to have "resctrl" in the name. The same goes for the exit
> call.
> 
> Rename x86's arch code init functions for RDT to have an arch
> prefix to make it clear these are part of the architecture code.

You aren't "exporting" these symbols in the Linux sense (as you
point out elsewhere in the series resctrl can't be built as a
module because the kernfs routines are not exported.

Maybe this commit description should just say it renames functions
to make it clear which are on the filesystem side of the boundary
and which are arch specific code?

-Tony