linux-kernel - Re: [PATCH v2] printk: Improve memory usage logging during boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zw_sB7wK97w4Y0Fe@google.com>
Date: Wed, 16 Oct 2024 09:38:31 -0700
From: Isaac Manjarres <isaacmanjarres@...gle.com>
To: Petr Mladek <pmladek@...e.com>
Cc: Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Sergey Senozhatsky <senozhatsky@...omium.org>, surenb@...gle.com,
	kernel-team@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] printk: Improve memory usage logging during boot

On Wed, Oct 16, 2024 at 12:24:35PM +0200, Petr Mladek wrote:
> I am sorry for the delay and thanks for the reminder. Last weeks were
> a bit hectic...
> 
> Anyway, I have just comitted the patch into printk/linux.git,
> branch for-6.13.
> 
> Note:
> 
> I have updated the sample messages in the commit message as suggested
> earlier.
> 
> Also I double checked the patch and simplified the comment
> in the following hunk. The original one was a bit cryptic.
> 
> @@ -1185,20 +1196,25 @@ void __init setup_log_buf(int early)
>  	if (!early && !new_log_buf_len)
>  		log_buf_add_cpu();
>  
> -	if (!new_log_buf_len)
> +	if (!new_log_buf_len) {
> +		/* Show the memory stats only once. */
> +		if (!early)
> +			goto out;
> +
>  		return;
> +	}
> 
> , see also
> https://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git/commit/?h=for-6.13&id=a961ec4e2860af4933e8c1763fe4f038c2d6ac80
> 
> Best Regards,
> Petr

No worries! I completely understand. Thank you for merging the patch
into your tree, and for cleaning up the commit message/comment.

Thanks,
Isaac