linux-kernel - [PATCH RESEND] arm: dts: nxp: lpc: lpc32xx: drop 'clocks' form rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20241016-lpc32xx-drop-rtc-clock-v1-1-5b271804d3e4@gmail.com>
Date: Wed, 16 Oct 2024 19:14:05 +0200
From: Javier Carrasco <javier.carrasco.cruz@...il.com>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, Vladimir Zapolskiy <vz@...ia.com>, 
 Piotr Wojtaszczyk <piotr.wojtaszczyk@...esys.com>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
 linux-kernel@...r.kernel.org, 
 Javier Carrasco <javier.carrasco.cruz@...il.com>
Subject: [PATCH RESEND] arm: dts: nxp: lpc: lpc32xx: drop 'clocks' form rtc

The RTC does not provide a controllable clock signal (it uses a fixed
32768 Hz crystal, the input clock of the SoC). Remove the 'clocks'
property to better describe the device and avoid errors when checking
the dts against the nxp,lpc3220-rtc binding.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
---
This patch used to belong to a series that converted the affected RTC
into dtschema[1] (effectively moving it to trivial-rtc), and dropped
the signal clock as it uses a fixed 32768 Hz crystal.

The rest of that series was merged, but I did not get any feedback for
this one. I sent a little reminder ~2 months later that might have gone
unnoticed too, and as a few more months passed since then, I opted for a
resend with the single pending patch. It is of course not urgent, but
still relevant.

Link: https://lore.kernel.org/all/20240413-rtc_dtschema-v3-0-eff368bcc471@gmail.com/ [1]
---
 arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
index 974410918f35..f78d67e672b4 100644
--- a/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
+++ b/arch/arm/boot/dts/nxp/lpc/lpc32xx.dtsi
@@ -384,7 +384,6 @@ rtc: rtc@...24000 {
 				reg = <0x40024000 0x1000>;
 				interrupt-parent = <&sic1>;
 				interrupts = <20 IRQ_TYPE_LEVEL_HIGH>;
-				clocks = <&clk LPC32XX_CLK_RTC>;
 			};
 
 			gpio: gpio@...28000 {

---
base-commit: 15e7d45e786a62a211dd0098fee7c57f84f8c681
change-id: 20241016-lpc32xx-drop-rtc-clock-32acf8f25011

Best regards,
-- 
Javier Carrasco <javier.carrasco.cruz@...il.com>