lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ba5a5208-50c5-4f84-b1e2-18fa9bbe3b75@baylibre.com>
Date: Wed, 16 Oct 2024 20:32:14 +0200
From: Guillaume LA ROQUE <glaroque@...libre.com>
To: Thomas Gleixner <tglx@...utronix.de>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>,
 Santosh Shilimkar <ssantosh@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 vishalm@...com, Mattijs Korpershoek <mkorpershoek@...libre.com>,
 Kevin Hilman <khilman@...libre.com>, Nicolas Frayer <nfrayer@...libre.com>
Subject: Re: [PATCH v3 1/2] irqchip: Kconfig: module build support for the TI
 interrupt router driver

Hi ,

Le 16/10/2024 à 18:38, Thomas Gleixner a écrit :
> On Wed, Oct 16 2024 at 11:41, Guillaume La Roque wrote:
>> From: Nicolas Frayer <nfrayer@...libre.com>
> irqchip: Kconfig: is not a valid prefix.
>
> This is about the TI SCI router, so this wants to use the
> irqchip/ti-whatever prefix.
>
>> Added module build support in Kconfig for the TI SCI interrupt router
>> driver
> Added?
>
> This wants to be 'Add ...'
>
> You fail to explain why it is valid to build this as a module, i.e. you
> did the analysis that there is no dependency on this before modules can
> be loaded.


i will rewrite commit message and title .

>
>>   MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@...om>");
>>   MODULE_DESCRIPTION("K3 Interrupt Router driver over TI SCI protocol");
>> +MODULE_LICENSE("GPL");
> This change is not mentioned in the change log.

it's mandatory for have possiblity to build in module so for me no 
really needed to explain this but i will add why in commit message.


thanks for review.

Guillaume

>
> Thanks,
>
>          tglx



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ