linux-kernel - Re: [RFC v7 4/6] gpio: mpfs: add polarfire soc gpio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZZeDyHJPZBuqnK1o+nWXgSAgNO7RceYB3Ao4tEOGRpDQ@mail.gmail.com>
Date: Wed, 16 Oct 2024 21:25:01 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Conor Dooley <conor@...nel.org>
Cc: Conor Dooley <conor.dooley@...rochip.com>, linux-kernel@...r.kernel.org, 
	Marc Zyngier <maz@...nel.org>, Daire McNamara <daire.mcnamara@...rochip.com>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	linux-riscv@...ts.infradead.org, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, Lewis Hanly <lewis.hanly@...rochip.com>
Subject: Re: [RFC v7 4/6] gpio: mpfs: add polarfire soc gpio support

On Wed, Oct 16, 2024 at 11:56 AM Conor Dooley <conor@...nel.org> wrote:

> I dunno if I'm making a mistake here, but I don't know if there's much
> value in implementing this suggestion - as far as I can tell only the
> get()/set() functions can be replaced by what's provided by gpio-mmio.c.

You're not making any mistake, you know the driver and hw better
than me.

Just skip the GPIO_MMIO if you think the result would look ugly.

You can add my:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij