linux-kernel - Re: [PATCH -next] iio: imu: bmi270: Remove duplicated include in bmi270

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <v3xzvojyycil7jszgxfnrwjiqxonz6aqrmfs6hgmru7pfuzgyv@3qrbzqo6p5mk>
Date: Tue, 15 Oct 2024 22:31:57 -0400
From: Alex Lanzano <lanzano.alex@...il.com>
To: Yang Li <yang.lee@...ux.alibaba.com>
Cc: jic23@...nel.org, lars@...afoo.de, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] iio: imu: bmi270: Remove duplicated include in
 bmi270_i2c.c

On Wed, Oct 16, 2024 at 08:39:19AM +0800, Yang Li wrote:
> The header files linux/module.h is included twice in bmi270_i2c.c,
> so one inclusion of each can be removed.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11363
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/iio/imu/bmi270/bmi270_i2c.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
> index e9025d22d5cc..71cc271cdf30 100644
> --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> @@ -3,7 +3,6 @@
>  #include <linux/module.h>
>  #include <linux/i2c.h>
>  #include <linux/iio/iio.h>
> -#include <linux/module.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/regmap.h>

Good catch!

Minor nit: Should remove the top module.h include instead to keep
alphabetical ordering.