linux-kernel - Re: [PATCH][next] pinctrl: th1520: Fix potential null pointer dereference on func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYxsGC5Yay0dOaQEegrLKKkLrcivX7_GVpfQsEa=psdDA@mail.gmail.com>
Date: Wed, 16 Oct 2024 21:32:55 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Colin Ian King <colin.i.king@...il.com>, Kees Cook <kees@...nel.org>, 
	Kees Bakker <kees@...erbout.nl>
Cc: Drew Fustini <drew@...7.com>, Guo Ren <guoren@...nel.org>, Fu Wei <wefu@...hat.com>, 
	Emil Renner Berthing <emil.renner.berthing@...onical.com>, linux-riscv@...ts.infradead.org, 
	linux-gpio@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] pinctrl: th1520: Fix potential null pointer
 dereference on func

On Wed, Oct 16, 2024 at 9:31 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> On Wed, Oct 16, 2024 at 5:56 PM Colin Ian King <colin.i.king@...il.com> wrote:
>
> > The initialization of muxtype deferences pointer func before func
> > is sanity checked with a null pointer check, hence we have a null
> > pointer deference issue. Fix this by only deferencing func with
> > the assignment to muxtype after func has been null pointer checked.
> >
> > Fixes: 1fc30cd92770 ("pinctrl: th1520: Factor out casts")
> > Signed-off-by: Colin Ian King <colin.i.king@...il.com>
>
> Patch applied, added Reported-by Kees since he mailed about this too.

...which was actually the "other Kees" (Bakker), not the one the mailer
suggested.

Yours,
Linus Walleij