linux-kernel - Re: [PATCH v3 1/2] virt: pvmemcontrol: control guest physical memory properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024101657-motion-lunacy-dc6d@gregkh>
Date: Wed, 16 Oct 2024 21:44:33 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Yuanchu Xie <yuanchu@...gle.com>
Cc: Wei Liu <liuwe@...rosoft.com>, Rob Bradford <rbradford@...osinc.com>,
	Theodore Ts'o <tytso@....edu>,
	Pasha Tatashin <pasha.tatashin@...een.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	virtualization@...ts.linux.dev, dev@...ts.cloudhypervisor.org
Subject: Re: [PATCH v3 1/2] virt: pvmemcontrol: control guest physical memory
 properties

On Wed, Oct 16, 2024 at 12:39:46PM -0700, Yuanchu Xie wrote:
> +	dev_info(dev->device,
> +		 "pvmemcontrol_vmm_info.ret_errno = %u\n"
> +		 "pvmemcontrol_vmm_info.ret_code = %u\n"
> +		 "pvmemcontrol_vmm_info.major_version = %llu\n"
> +		 "pvmemcontrol_vmm_info.minor_version = %llu\n"
> +		 "pvmemcontrol_vmm_info.page_size = %llu\n",
> +		 dev->pvmemcontrol_vmm_info.ret_errno,
> +		 dev->pvmemcontrol_vmm_info.ret_code,
> +		 dev->pvmemcontrol_vmm_info.arg0,
> +		 dev->pvmemcontrol_vmm_info.arg1,
> +		 dev->pvmemcontrol_vmm_info.ret_value);

When a driver works properly, it is quiet.  Please do not spam the
kernel log when your driver properly binds to the device like this,
that's just not ok at all.

thanks,

greg k-h