linux-kernel - Re: [PATCH v9 3/3] drm/rockchip: Add basic RK3588 HDMI output support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e5f1d4ea-4b8d-4f42-9025-5291baddf7e5@collabora.com>
Date: Wed, 16 Oct 2024 23:11:53 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Andrzej Hajda <andrzej.hajda@...el.com>,
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Sandy Huang <hjc@...k-chips.com>,
 Heiko Stübner <heiko@...ech.de>,
 Andy Yan <andy.yan@...k-chips.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Mark Yao <markyao0591@...il.com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Simona Vetter <simona@...ll.ch>,
 Simona Vetter <simona.vetter@...ll.ch>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
 kernel@...labora.com, Alexandre ARNOUD <aarnoud@...com>,
 Luis de Arquer <ldearquer@...il.com>, Algea Cao <algea.cao@...k-chips.com>
Subject: Re: [PATCH v9 3/3] drm/rockchip: Add basic RK3588 HDMI output support

Hi,

On 10/16/24 12:27 PM, Uwe Kleine-König wrote:
> Hello,
> 
> On Thu, Oct 10, 2024 at 01:40:51AM +0300, Cristian Ciocaltea wrote:
>> +struct platform_driver dw_hdmi_qp_rockchip_pltfm_driver = {
>> +	.probe  = dw_hdmi_qp_rockchip_probe,
>> +	.remove_new = dw_hdmi_qp_rockchip_remove,
>> +	.driver = {
>> +		.name = "dwhdmiqp-rockchip",
>> +		.pm = &dw_hdmi_qp_rockchip_pm,
>> +		.of_match_table = dw_hdmi_qp_rockchip_dt_ids,
>> +	},
>> +};
> 
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
> 
> Additionally I suggest to drop one of the white spaces between .probe
> and =.

Handled both in v10 [1].

Thanks,
Cristian

[1] https://lore.kernel.org/all/20241016-b4-rk3588-bridge-upstream-v10-0-87ef92a6d14e@collabora.com/