linux-kernel - Re: [PATCH v3 08/12] arm64: dts: renesas: r9a08g045: Add RTC node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024101622034648032b39@mail.local>
Date: Thu, 17 Oct 2024 00:03:46 +0200
From: Alexandre Belloni <alexandre.belloni@...tlin.com>
To: claudiu beznea <claudiu.beznea@...on.dev>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>, mturquette@...libre.com,
	sboyd@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org, magnus.damm@...il.com, p.zabel@...gutronix.de,
	linux-renesas-soc@...r.kernel.org, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-rtc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v3 08/12] arm64: dts: renesas: r9a08g045: Add RTC node

On 11/10/2024 13:28:55+0300, claudiu beznea wrote:
> >> +                       compatible = "renesas,r9a08g045-rtca3", "renesas,rz-rtca3";
> >> +                       reg = <0 0x1004ec00 0 0x400>;
> >> +                       interrupts = <GIC_SPI 315 IRQ_TYPE_LEVEL_HIGH>,
> >> +                                    <GIC_SPI 316 IRQ_TYPE_LEVEL_HIGH>,
> >> +                                    <GIC_SPI 317 IRQ_TYPE_LEVEL_HIGH>;
> >> +                       interrupt-names = "alarm", "period", "carry";
> >> +                       clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb VBATTB_VBATTCLK>;
> >> +                       clock-names = "bus", "counter";
> >> +                       assigned-clocks = <&vbattb VBATTB_MUX>;
> >> +                       assigned-clock-parents = <&vbattb VBATTB_XC>;
> > 
> > Don't the assigned-clock* properties belong in the board DTS?
> 
> It makes sense to be in the board DTS, indeed.
> 
> > In addition, I think they should be documented in the DT bindings,
> > and be made required, so board developers don't forget about them.
> 
> It would be better, indeed.

There were multiple recent emails from Rob saying that assigned-clocks
should not be part of the bindings.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com