linux-kernel - Re: [PATCH RESEND] mm: shmem: fix data-race in shmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20241016151636.7e2184ca7467a0f8f90d940c@linux-foundation.org>
Date: Wed, 16 Oct 2024 15:16:36 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Jeongjun Park <aha310510@...il.com>
Cc: hughd@...gle.com, yuzhao@...gle.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, syzbot <syzkaller@...glegroups.com>,
 stable@...r.kernel.org
Subject: Re: [PATCH RESEND] mm: shmem: fix data-race in shmem_getattr()

On Wed, 16 Oct 2024 23:12:43 +0900 Jeongjun Park <aha310510@...il.com> wrote:

> > Therefore, when calling generic_fillattr() from shmem_getattr(), it is
> > appropriate to protect the inode using inode_lock_shared() and
> > inode_unlock_shared() to prevent data-race.
> >
> 
> Cc: stable@...r.kernel.org
> 
> I think this patch should be applied from next rc version and also stable
> version. When calling generic_fillattr(), if you don't hold read lock,
> data-race will occur in inode member variables, which can cause unexpected
> behavior. This problem is also present in several stable versions, so I think
> it should be fixed as soon as possible.

OK, thanks, I added the cc:stable amd moved this into the mm-hotfixes
pile for a 6.12-rcX merge.