linux-kernel - RE: [PATCH v3 2/2] irqchip/aspeed-intc: Add support for AST27XX INTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PSAPR06MB49496AB83001EDA4A51F263189462@PSAPR06MB4949.apcprd06.prod.outlook.com>
Date: Wed, 16 Oct 2024 00:31:00 +0000
From: Kevin Chen <kevin_chen@...eedtech.com>
To: Thomas Gleixner <tglx@...utronix.de>, Markus Elfring
	<Markus.Elfring@....de>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Andrew Jeffery <andrew@...econstruct.com.au>,
	Conor Dooley <conor+dt@...nel.org>, Joel Stanley <joel@....id.au>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>
CC: LKML <linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH v3 2/2] irqchip/aspeed-intc: Add support for AST27XX INTC

> >> +
> >> +	chained_irq_enter(chip, desc);
> >
> > Would you become interested to collaborate with another scoped guard
> > for this programming interface?
> 
> Collaborate in which way? What are you collaborating on?
> 
> You are merely asking people to do work which you think is useful. You can do
> that, but that does not make it useful.
> 
> Making a guard variant of chained_irq_enter/exit needs some thought and a
> general plan for cleaning the whole chained irq usage up. It's on the cleanup
> list already with quite some other items.
> 
> We are not adhoc adding a guard variant because guards are hip right now.
> And no this does not need a scoped variant ever.
> 
> guards are not the panacea for everything.
> 
> > https://elixir.bootlin.com/linux/v6.12-rc2/source/include/linux/irqchi
> > p/chained_irq.h#L13
> 
> Please refrain from these silly links. People know to find the functions on their
> own.
> 
> Kevin, please update the change log, add your SOB and move the local
> variables (unsigned long bit, status;) into the scoped_guard() zone.
OK. I will do this change.

> 
> Leave chained_irq_enter/exit() alone and resubmit.
OK. I will send the v4 patch with chained_irq_enter/exit() alone.

Thanks a lot.

> 
> Thanks,
> 
>         tglx