linux-kernel - Re: [PATCH v2] smb: client: fix possible double free in smb2_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5msLmsCn_uHqyzFy8CXy6uCheOECNSXLReJdS4u1C4aN0w@mail.gmail.com>
Date: Wed, 16 Oct 2024 00:35:56 -0500
From: Steve French <smfrench@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Su Hui <suhui@...china.com>, sfrench@...ba.org, pc@...guebit.com, 
	ronniesahlberg@...il.com, sprasad@...rosoft.com, stfrench@...rosoft.com, 
	tom@...pey.com, bharathsm@...rosoft.com, nathan@...nel.org, 
	ndesaulniers@...gle.com, morbo@...gle.com, justinstitt@...gle.com, 
	linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org, 
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] smb: client: fix possible double free in smb2_set_ea()

merged into cifs-2.6.git for-next pending additional testing

On Tue, Oct 15, 2024 at 5:45 AM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> On Tue, Oct 15, 2024 at 06:20:37PM +0800, Su Hui wrote:
> > Clang static checker(scan-build) warning：
> > fs/smb/client/smb2ops.c:1304:2: Attempt to free released memory.
> >  1304 |         kfree(ea);
> >       |         ^~~~~~~~~
> >
> > There is a double free in such case:
> > 'ea is initialized to NULL' -> 'first successful memory allocation for
> > ea' -> 'something failed, goto sea_exit' -> 'first memory release for ea'
> > -> 'goto replay_again' -> 'second goto sea_exit before allocate memory
> > for ea' -> 'second memory release for ea resulted in double free'.
> >
> > Re-initialie 'ea' to NULL near to the replay_again label, it can fix this
> > double free problem.
> >
> > Fixes: 4f1fffa23769 ("cifs: commands that are retried should have replay flag set")
> > Signed-off-by: Su Hui <suhui@...china.com>
> > ---
> > v2:
> > - Move 'ea = NULL' near to the replay_again label.(Dan's suggestion)
>
> Thanks!
>
> Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>
>
> regards,
> dan carpenter
>
>


-- 
Thanks,

Steve