| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202410161414.jC5t2eWE-lkp@intel.com>
Date: Wed, 16 Oct 2024 14:19:08 +0800
From: kernel test robot <lkp@...el.com>
To: Sven Schnelle <svens@...ux.ibm.com>, Heiko Carstens <hca@...ux.ibm.com>,
Vasily Gorbik <gor@...ux.ibm.com>,
Alexander Gordeev <agordeev@...ux.ibm.com>,
Christian Borntraeger <borntraeger@...ux.ibm.com>,
Richard Cochran <richardcochran@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Ricardo B. Marliere" <ricardo@...liere.net>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH 3/3] s390/time: Add PtP driver
Hi Sven,
kernel test robot noticed the following build errors:
[auto build test ERROR on s390/features]
[also build test ERROR on linus/master v6.12-rc3 next-20241015]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sven-Schnelle/s390-time-Add-clocksource-id-to-TOD-clock/20241015-185651
base: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
patch link: https://lore.kernel.org/r/20241015105414.2825635-4-svens%40linux.ibm.com
patch subject: [PATCH 3/3] s390/time: Add PtP driver
config: x86_64-buildonly-randconfig-003-20241016 (https://download.01.org/0day-ci/archive/20241016/202410161414.jC5t2eWE-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241016/202410161414.jC5t2eWE-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410161414.jC5t2eWE-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> drivers/ptp/ptp_s390.c:21:52: warning: declaration of 'union tod_clock' will not be visible outside of this function [-Wvisibility]
21 | static struct timespec64 eitod_to_timespec64(union tod_clock *clk)
| ^
>> drivers/ptp/ptp_s390.c:23:26: error: call to undeclared function 'eitod_to_ns'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
23 | return ns_to_timespec64(eitod_to_ns(clk));
| ^
>> drivers/ptp/ptp_s390.c:28:26: error: call to undeclared function 'tod_to_ns'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
28 | return ns_to_timespec64(tod_to_ns(tod - TOD_UNIX_EPOCH));
| ^
>> drivers/ptp/ptp_s390.c:28:42: error: use of undeclared identifier 'TOD_UNIX_EPOCH'
28 | return ns_to_timespec64(tod_to_ns(tod - TOD_UNIX_EPOCH));
| ^
>> drivers/ptp/ptp_s390.c:34:18: error: variable has incomplete type 'union tod_clock'
34 | union tod_clock tod;
| ^
drivers/ptp/ptp_s390.c:34:8: note: forward declaration of 'union tod_clock'
34 | union tod_clock tod;
| ^
>> drivers/ptp/ptp_s390.c:36:7: error: call to undeclared function 'stp_enabled'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
36 | if (!stp_enabled())
| ^
>> drivers/ptp/ptp_s390.c:39:2: error: call to undeclared function 'store_tod_clock_ext_cc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
39 | store_tod_clock_ext_cc(&tod);
| ^
>> drivers/ptp/ptp_s390.c:49:2: error: call to undeclared function 'ptff'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
49 | ptff(&tod, sizeof(tod), PTFF_QPT);
| ^
>> drivers/ptp/ptp_s390.c:49:26: error: use of undeclared identifier 'PTFF_QPT'
49 | ptff(&tod, sizeof(tod), PTFF_QPT);
| ^
drivers/ptp/ptp_s390.c:64:18: error: variable has incomplete type 'union tod_clock'
64 | union tod_clock clk;
| ^
drivers/ptp/ptp_s390.c:64:8: note: forward declaration of 'union tod_clock'
64 | union tod_clock clk;
| ^
drivers/ptp/ptp_s390.c:66:2: error: call to undeclared function 'store_tod_clock_ext_cc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
66 | store_tod_clock_ext_cc(&clk);
| ^
drivers/ptp/ptp_s390.c:67:29: error: call to undeclared function 'tod_to_ns'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
67 | *device_time = ns_to_ktime(tod_to_ns(clk.tod - TOD_UNIX_EPOCH));
| ^
drivers/ptp/ptp_s390.c:67:49: error: use of undeclared identifier 'TOD_UNIX_EPOCH'
67 | *device_time = ns_to_ktime(tod_to_ns(clk.tod - TOD_UNIX_EPOCH));
| ^
drivers/ptp/ptp_s390.c:76:7: error: call to undeclared function 'stp_enabled'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
76 | if (!stp_enabled())
| ^
1 warning and 13 errors generated.
vim +/eitod_to_ns +23 drivers/ptp/ptp_s390.c
20
> 21 static struct timespec64 eitod_to_timespec64(union tod_clock *clk)
22 {
> 23 return ns_to_timespec64(eitod_to_ns(clk));
24 }
25
26 static struct timespec64 tod_to_timespec64(unsigned long tod)
27 {
> 28 return ns_to_timespec64(tod_to_ns(tod - TOD_UNIX_EPOCH));
29 }
30
31 static int ptp_s390_stcke_gettime(struct ptp_clock_info *ptp,
32 struct timespec64 *ts)
33 {
> 34 union tod_clock tod;
35
> 36 if (!stp_enabled())
37 return -EOPNOTSUPP;
38
> 39 store_tod_clock_ext_cc(&tod);
40 *ts = eitod_to_timespec64(&tod);
41 return 0;
42 }
43
44 static int ptp_s390_qpt_gettime(struct ptp_clock_info *ptp,
45 struct timespec64 *ts)
46 {
47 unsigned long tod;
48
> 49 ptff(&tod, sizeof(tod), PTFF_QPT);
50 *ts = tod_to_timespec64(tod);
51 return 0;
52 }
53
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists