linux-kernel - Re: [PATCH] ASoC: loongson: make loongson-i2s.o a separate module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <887501dc-6bcc-4f98-b472-af609c4c370b@app.fastmail.com>
Date: Wed, 16 Oct 2024 07:02:36 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "Binbin Zhou" <zhoubinbin@...ngson.cn>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Liam Girdwood" <lgirdwood@...il.com>, "Mark Brown" <broonie@...nel.org>,
 "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai" <tiwai@...e.com>,
 "Tang Bin" <tangbin@...s.chinamobile.com>, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, "Binbin Zhou" <zhoubb.aaron@...il.com>
Subject: Re: [PATCH] ASoC: loongson: make loongson-i2s.o a separate module

On Wed, Oct 16, 2024, at 06:56, 周彬彬 wrote:
>> -----Original Messages-----
>> From: "Arnd Bergmann" <arnd@...nel.org>
>> Send time:Tuesday, 10/15/2024 23:09:54
>> To: "Liam Girdwood" <lgirdwood@...il.com>, "Mark Brown" <broonie@...nel.org>, "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai" <tiwai@...e.com>, "Binbin Zhou" <zhoubinbin@...ngson.cn>
>> Cc: "Arnd Bergmann" <arnd@...db.de>, tangbin <tangbin@...s.chinamobile.com>, linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org
>> Subject: [PATCH] ASoC: loongson: make loongson-i2s.o a separate module
>> 
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> An object file should not be linked into multiple modules and/or
>> vmlinux:
>> 
>> scripts/Makefile.build:221: /home/arnd/arm-soc/sound/soc/loongson/Makefile: loongson_i2s.o is added to multiple modules: snd-soc-loongson-i2s-pci snd-soc-loongson-i2s-plat
>
> I would like to ask for some advice.
> I didn't notice this warning before when I submitted the patch, is 
> there some specific compilation option that needs to be turned on?

I think this is one of the warnings that are currently
only enabled when building with "make W=1". I have this enabled
by default as I hope to make it a default warning soon.

In general, I would recommend to build new driver code with W=1
before submitting. 

     Arnd