lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2024101657-osmosis-fading-4380@gregkh>
Date: Wed, 16 Oct 2024 09:23:41 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Rohit Chavan <roheetchavan@...il.com>
Cc: Dave Penkler <dpenkler@...il.com>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Remove unneeded semicolon.

On Wed, Oct 16, 2024 at 12:49:41PM +0530, Rohit Chavan wrote:
> This patch cleans up the GPIB driver code by removing
> unneeded semicolons.

Nit, you can use all 72 columns.

> 
> Files modified:
> drivers/staging/gpib/tms9914/tms9914.c
> drivers/staging/gpib/tnt4882/mite.c

Why are these lines needed?  We know what files are modified by looking
at the diff :)

Please fix up and send a v2.

thanks,

greg k-

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ