linux-kernel - Re: [PATCH] staging: gpib: Remove unused value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEO-vhEiMG+Zb0-FqPBcYANnpnntA-H_D76wbAehgXDAUTYKOg@mail.gmail.com>
Date: Wed, 16 Oct 2024 01:40:46 -0600
From: "Everest K.C." <everestkc@...restkc.com.np>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: dpenkler@...il.com, skhan@...uxfoundation.org, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: Remove unused value

On Wed, Oct 16, 2024 at 1:37 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Oct 15, 2024 at 03:02:57PM -0600, Everest K.C. wrote:
> > The variable `complement_count` is assigned a value which is again
> > overwritten in the next statement.
> > Fix this by removing the first value assigning statement
> >
> > This issue was reported by Coverity Scan.
> > Report:
> > CID 1600790: (#1 of 1): Unused value (UNUSED_VALUE)
> > assigned_value: Assigning value from length to complement_count here,
> > but that stored value is overwritten before it can be used.
> >
> > Fixes: 4e127de14fa7 ("staging: gpib: Add National Instruments USB GPIB driver")
>
> Thre is no "fix" needed here.  It's not a bug, just a useless operation
> (one tha tthe compiler probably just compiles away into nothing.)  So
> there is no need for a Fixes: tag, sorry.
Noted. Will remove the fixes tag and send V2.
> thanks,
>
> greg k-h
Thanks,
Everest K.C.