linux-kernel - Re: [PATCH v2] ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f3836285-befc-92af-38ef-e58a84f920fd@basealt.ru>
Date: Wed, 16 Oct 2024 11:14:55 +0300
From: Vasiliy Kovalev <kovalev@...linux.org>
To: Takashi Iwai <tiwai@...e.de>, Kai-Heng Feng <kaihengf@...dia.com>
Cc: Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>,
 linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 bo liu <bo.liu@...arytech.com>
Subject: Re: [PATCH v2] ALSA: hda/conexant - Fix audio routing for HP EliteOne
 1000 G2


10.10.2024 11:36, Vasiliy Kovalev пишет:
> 
> 10.10.2024 08:17, Takashi Iwai wrote:
>> On Thu, 10 Oct 2024 05:32:18 +0200,
>> Kai-Heng Feng wrote:
>>>
>>>
>>> On 2024/10/9 9:50 PM, Takashi Iwai wrote:
>>>> On Wed, 09 Oct 2024 15:42:48 +0200,
>>>> Vasiliy Kovalev wrote:
>>>>>
>>>>> There is a problem with simultaneous audio output to headphones and
>>>>> speakers, and when headphones are turned off, the speakers also turn
>>>>> off and do not turn them on.
>>>>>
>>>>> However, it was found that if you boot linux immediately after 
>>>>> windows,
>>>>> there are no such problems. When comparing alsa-info, the only 
>>>>> difference
>>>>> is the different configuration of Node 0x1d:
>>>>>
>>>>> working conf. (windows): Pin-ctls: 0x80: HP
>>>>> not working     (linux): Pin-ctls: 0xc0: OUT HP
>>>>>
>>>>> This patch disable the AC_PINCTL_OUT_EN bit of Node 0x1d and fixes the
>>>>> described problem.
>>>
>>> Though this is already applied, is it possible to see if the issue
>>> also happens on S4?
>>>
>>> Linux doesn't put PCI devices like HDA to D3 during shutdown and
>>> reboot while Windows does, that might be the reason boot Linux after
>>> Windows can workaround the issue.
>>>
>>> Linux does put PCI devices to D3 for hibernate (S4), so we can use it
>>> as an experiment.
>>
>> Right, it should have been the cached version so that the setup is
>> reapplied automatically; i.e. replace snd_hda_set_pin_ctl() with
>> snd_hda_set_pin_ctl_cached().
>>
>> Vasiliy, care to test and submit an incremental fix?
> 
> Ok, I compiled the module with the proposed changes and sent it to the 
> user for testing on a machine with this codec. After testing, I will 
> write about the result.

Using the snd_hda_set_pin_ctl_cache() function instead of 
snd_hda_set_pin_ctl() leads to the same positive result, there are no 
problems with sound.  The patch has been sent [1]

[1] https://lore.kernel.org/all/20241016080713.46801-1-kovalev@altlinux.org/

>>
>> thanks,
>>
>> Takashi

--
Thanks,
Vasiliy Kovalev