linux-kernel - Re: [PATCH v2] selftest: hid: add the missing tests directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ioshjncgxafin7jcm7kne5fahp4l5nhk5664mnrdo7fgutgyn@jac5gopdyjty>
Date: Wed, 16 Oct 2024 10:27:43 +0200
From: Benjamin Tissoires <bentiss@...nel.org>
To: Yun Lu <luyun@...inos.cn>
Cc: jikos@...nel.org, shuah@...nel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftest: hid: add the missing tests directory

On Oct 15 2024, Yun Lu wrote:
> Commit 160c826b4dd0 ("selftest: hid: add missing run-hid-tools-tests.sh")
> has added the run-hid-tools-tests.sh script for it to be installed, but
> I forgot to add the tests directory together.
> 
> If running the test case without the tests directory,  will results in
> the following error message:
> 
>     make -C tools/testing/selftests/ TARGETS=hid install \
> 	    INSTALL_PATH=$KSFT_INSTALL_PATH
>     cd $KSFT_INSTALL_PATH
>     ./run_kselftest.sh -t hid:hid-core.sh
> 
>   /usr/lib/python3.11/site-packages/_pytest/config/__init__.py:331: PluggyTeardownRaisedWarning: A plugin raised an exception during an old-style hookwrapper teardown.
>   Plugin: helpconfig, Hook: pytest_cmdline_parse
>   UsageError: usage: __main__.py [options] [file_or_dir] [file_or_dir] [...]
>   __main__.py: error: unrecognized arguments: --udevd
>     inifile: None
>     rootdir: /root/linux/kselftest_install/hid
> 
> In fact, the run-hid-tools-tests.sh script uses the scripts in the tests
> directory to run tests. The tests directory also needs to be added to be
> installed.
> 
> v2: add the error message
> 
> Fixes: ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")
> Cc: stable@...r.kernel.org
> Signed-off-by: Yun Lu <luyun@...inos.cn>

Acked-by: Benjamin Tissoires <bentiss@...nel.org>

Shuah, I guess you'll want to take this one through your tree given that
you already took the run-hid-tools-tests.sh one?

Cheers,
Benjamin

> ---
>  tools/testing/selftests/hid/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile
> index 38ae31bb07b5..662209f5fabc 100644
> --- a/tools/testing/selftests/hid/Makefile
> +++ b/tools/testing/selftests/hid/Makefile
> @@ -18,6 +18,7 @@ TEST_PROGS += hid-usb_crash.sh
>  TEST_PROGS += hid-wacom.sh
>  
>  TEST_FILES := run-hid-tools-tests.sh
> +TEST_FILES += tests
>  
>  CXX ?= $(CROSS_COMPILE)g++
>  
> -- 
> 2.27.0
>