[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zw+JMMUOErRKqEH1@linaro.org>
Date: Wed, 16 Oct 2024 12:36:48 +0300
From: Abel Vesa <abel.vesa@...aro.org>
To: Pengfei Li <pengfei.li_1@....com>
Cc: krzk+dt@...nel.org, robh@...nel.org, abelvesa@...nel.org,
mturquette@...libre.com, sboyd@...nel.org, conor+dt@...nel.org,
shawnguo@...nel.org, s.hauer@...gutronix.de, ping.bai@....com,
ye.li@....com, peng.fan@....com, aisheng.dong@....com,
frank.li@....com, kernel@...gutronix.de, festevam@...il.com,
linux-clk@...r.kernel.org, imx@...ts.linux.dev,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/4] clk: imx93: Move IMX93_CLK_END macro to clk driver
On 24-10-14 11:24:35, Pengfei Li wrote:
> IMX93_CLK_END was previously defined in imx93-clock.h to indicate
> the number of clocks. However, it is not part of the ABI. For starters
> it does no really appear in DTS. But what's more important - new clocks
> are described later, which contradicts this define in binding header.
> So move this macro to clock driver.
>
> Signed-off-by: Pengfei Li <pengfei.li_1@....com>
> ---
> drivers/clk/imx/clk-imx93.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c
> index c6a9bc8ecc1f..c8b65146e76e 100644
> --- a/drivers/clk/imx/clk-imx93.c
> +++ b/drivers/clk/imx/clk-imx93.c
> @@ -15,6 +15,8 @@
>
> #include "clk.h"
>
> +#define IMX93_CLK_END 202
> +
Sorry for this back and forth.
I've been discussing this off-list with Krzysztof and others and
now I think this is actually not wrong.
So:
Reviewed-by: Abel Vesa <abel.vesa@...aro.org>
> enum clk_sel {
> LOW_SPEED_IO_SEL,
> NON_IO_SEL,
> --
> 2.34.1
>
Powered by blists - more mailing lists