linux-kernel - [PATCH v2] csky: fix csky_cmpxchg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241016095626.8162-1-yang.li85200@gmail.com>
Date: Wed, 16 Oct 2024 17:56:26 +0800
From: Yang Li <yang.li85200@...il.com>
To: yang.li85200@...il.com
Cc: guoren@...nel.org,
	linux-csky@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH v2] csky: fix csky_cmpxchg_fixup not working

In the csky_cmpxchg_fixup function, it is incorrect to use the global
 variable csky_cmpxchg_stw to determine the address where the exception
 occurred.The global variable csky_cmpxchg_stw stores the opcode at the
 time of the exception, while &csky_cmpxchg_stw shows the address where
 the exception occurred.

Signed-off-by: Yang Li <yang.li85200@...il.com>
---
V1 -> V2:Eliminate compilation warnings

 arch/csky/mm/fault.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/csky/mm/fault.c b/arch/csky/mm/fault.c
index a885518ce1dd..5226bc08c336 100644
--- a/arch/csky/mm/fault.c
+++ b/arch/csky/mm/fault.c
@@ -45,8 +45,8 @@ static inline void csky_cmpxchg_fixup(struct pt_regs *regs)
 	if (trap_no(regs) != VEC_TLBMODIFIED)
 		return;
 
-	if (instruction_pointer(regs) == csky_cmpxchg_stw)
-		instruction_pointer_set(regs, csky_cmpxchg_ldw);
+	if (instruction_pointer(regs) == (unsigned long)&csky_cmpxchg_stw)
+		instruction_pointer_set(regs, (unsigned long)&csky_cmpxchg_ldw);
 	return;
 }
 #endif
-- 
2.34.1