linux-kernel - Re: [PATCH v6 2/2] clk: mediatek: Add drivers for MediaTek MT6735 main clock and reset drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad000fdb-4474-49c4-9357-f23491231b07@collabora.com>
Date: Wed, 16 Oct 2024 11:57:12 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Yassine Oudjana <yassine.oudjana@...il.com>
Cc: Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Sam Shih <sam.shih@...iatek.com>,
 Daniel Golle <daniel@...rotopia.org>, Bartosz Golaszewski <brgl@...ev.pl>,
 Yassine Oudjana <y.oudjana@...tonmail.com>, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 2/2] clk: mediatek: Add drivers for MediaTek MT6735
 main clock and reset drivers

Il 16/10/24 11:28, Uwe Kleine-König ha scritto:
> Hello,
> 
> On Thu, Oct 10, 2024 at 04:26:57PM +0300, Yassine Oudjana wrote:
>> +static struct platform_driver clk_mt6735_apmixedsys = {
>> +	.probe = clk_mt6735_apmixed_probe,
>> +	.remove_new = clk_mt6735_apmixed_remove,
>> +	.driver = {
>> +		.name = "clk-mt6735-apmixedsys",
>> +		.of_match_table = of_match_mt6735_apmixedsys,
>> +	},
>> +};
> 
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
> 

Oh wow, I didn't notice that during my review. Sorry about that.

Cheers,
Angelo