linux-kernel - Re: [PATCH 2/2] dt-bindings: hwmon: pmbus: pli209bc: Add bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABqG17irpNCUks=zg5OpEXqSCUNtWm9X3CpdcZ7AkL0fBdEySA@mail.gmail.com>
Date: Wed, 16 Oct 2024 15:50:20 +0530
From: Naresh Solanki <naresh.solanki@...ements.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Sylvester Bauer <sylv@...v.io>, 
	linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: hwmon: pmbus: pli209bc: Add bindings

Hi Krzysztof,

On Tue, 15 Oct 2024 at 17:18, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 15/10/2024 13:33, Naresh Solanki wrote:
> > Add bindings for Vicor pli1209bc.
> > It a Digital Supervisor with Isolation for use with BCM Bus Converter
> > Modules.
> >
> > Signed-off-by: Naresh Solanki <naresh.solanki@...ements.com>
> > ---
> >  .../bindings/hwmon/pmbus/vicor,pli1209bc.yaml | 65 +++++++++++++++++++
>
> This has to be squashed with previous patch.
>
> >  1 file changed, 65 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> > new file mode 100644
> > index 000000000000..3647d14e9111
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/vicor,pli1209bc.yaml
> > @@ -0,0 +1,65 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +
>
> Drop blank line
Ack
>
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,pli1209bc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Vicor PLI1209BC Power Regulator
> > +
> > +maintainers:
> > +  - Marcello Sylvester Bauer <sylv@...v.io>
> > +  - Naresh Solanki <naresh.solanki@...ements.com>
> > +
> > +description: |
>
> Do not need '|' unless you need to preserve formatting.
Ack
>
> > +  The Vicor PLI1209BC is a Digital Supervisor with Isolation for use
> > +  with BCM Bus Converter Modules.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - vicor,pli1209bc
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  regulators:
>
> Drop the node and define vout2 here directly.... unless anything needs
> such layout? Then explain this in commit msg.
This is expected by pmbus regulator driver:
https://github.com/torvalds/linux/blob/master/drivers/hwmon/pmbus/pmbus.h#L512
>
> > +    type: object
> > +    description:
> > +      List of regulators provided by this controller.
> > +
> > +    properties:
> > +      vout2:
> > +        $ref: /schemas/regulator/regulator.yaml#
> > +        type: object
> > +
>
> Drop blank line.
Ack
>
> > +        unevaluatedProperties: false
> > +
> > +    additionalProperties: false
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
>
> Drop, not used.
Ack
>
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        pli1209bc_p12v_d: regulator@5f {
>
> Drop unused prefix
Ack

Regards,
Naresh
>
> > +            compatible = "vicor,pli1209bc";
> > +            reg = <0x5f>;
> > +
> > +            regulators {
> > +                p12v_d: vout2 {
> > +                    regulator-name = "bcm3";
> > +                    regulator-boot-on;
> > +                };
> > +            };
> > +        };
> > +    };
> > +
>
> Best regards,
> Krzysztof
>