linux-kernel - Re: [PATCH v4 02/28] media: iris: add platform driver for iris video device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66cf771e-1663-e85c-02e8-524427ab40ec@quicinc.com>
Date: Wed, 16 Oct 2024 15:59:57 +0530
From: Dikshita Agarwal <quic_dikshita@...cinc.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
CC: Vikash Garodia <quic_vgarodia@...cinc.com>,
        Abhinav Kumar
	<quic_abhinavk@...cinc.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Rob
 Herring" <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "Conor
 Dooley" <conor+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "Hans
 Verkuil" <hverkuil@...all.nl>,
        Sebastian Fricke
	<sebastian.fricke@...labora.com>,
        <linux-arm-msm@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 02/28] media: iris: add platform driver for iris video
 device



On 10/16/2024 3:08 PM, Uwe Kleine-König wrote:
> Hello,
> 
> On Mon, Oct 14, 2024 at 02:37:23PM +0530, Dikshita Agarwal wrote:
>> +static struct platform_driver qcom_iris_driver = {
>> +	.probe = iris_probe,
>> +	.remove_new = iris_remove,
>> +	.driver = {
>> +		.name = "qcom-iris",
>> +		.of_match_table = iris_dt_match,
>> +	},
>> +};
> 
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
> 
Noted, Thanks!

Regards,
Dikshita
> Best regards
> Uwe