linux-kernel - Re: [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7865e7ee-d894-4ef4-89c4-5ea3a90ac6f1@collabora.com>
Date: Wed, 16 Oct 2024 12:52:50 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Rob Herring <robh@...nel.org>, Macpaul Lin <macpaul.lin@...iatek.com>
Cc: Chunfeng Yun <chunfeng.yun@...iatek.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>,
 ChiYuan Huang <cy_huang@...htek.com>, linux-usb@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Bear Wang <bear.wang@...iatek.com>, Pablo Sun <pablo.sun@...iatek.com>,
 Macpaul Lin <macpaul@...il.com>,
 Project_Global_Chrome_Upstream_Group@...iatek.com,
 Chris-qj chen <chris-qj.chen@...iatek.com>
Subject: Re: [PATCH] dt-bindings: usb: mtu3: add mediatek,usb3-drd property

Il 16/10/24 00:20, Rob Herring ha scritto:
> On Wed, Oct 16, 2024 at 01:21:00AM +0800, Macpaul Lin wrote:
>> Add optional 'mediatek,usb3-drd' property to MediaTek MTU3 DT Schema.
>> This flag specify whether it is a USB3 Dual-role device hardware.
>>
>> Signed-off-by: Macpaul Lin <macpaul.lin@...iatek.com>
>> ---
>>   Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> index d4e187c78a0b..1e70af0dac82 100644
>> --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
>> @@ -155,6 +155,12 @@ properties:
>>         property is used. See graph.txt
>>       $ref: /schemas/graph.yaml#/properties/port
>>   
>> +  mediatek,usb3-drd:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description:
>> +      Specify whether it is a USB3 Dual-role device hardware.
>> +    type: boolean
>> +
> 
> Don't the standard properties such as usb-role-switch or dr_mode work
> for you?
> 

They do - and in fact, the upstream MTU3 driver doesn't even support parsing
the proposed property because it does parse the standard usb-role-switch property.

This means that this commit is not needed at all.

Cheers,
Angelo

>>     enable-manual-drd:
>>       $ref: /schemas/types.yaml#/definitions/flag
>>       description:
>> -- 
>> 2.45.2
>>