linux-kernel - Re: [PATCH 1/3] dt-bindings: sound: Add CS42L84 codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172907743814.946384.14631158473077396509.robh@kernel.org>
Date: Wed, 16 Oct 2024 06:17:18 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: James Calligeros <jcalligeros99@...il.com>
Cc: Richard Fitzgerald <rf@...nsource.cirrus.com>, 
 patches@...nsource.cirrus.com, 
 Martin Povišer <povik+lin@...ebit.org>, 
 Takashi Iwai <tiwai@...e.com>, Mark Brown <broonie@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, 
 Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org, 
 Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org, 
 devicetree@...r.kernel.org, asahi@...ts.linux.dev, 
 David Rhodes <david.rhodes@...rus.com>
Subject: Re: [PATCH 1/3] dt-bindings: sound: Add CS42L84 codec

On Wed, 16 Oct 2024 20:41:00 +1000, James Calligeros wrote:
> From: Martin Povišer <povik+lin@...ebit.org>
> 
> CS42L84 is a headphone jack codec made by Cirrus Logic and seen in Apple
> computer models starting with 2021 Macbook Pros. It is not a publicly
> documented part. To a degree the part is similar to the public CS42L42.
> (The L84 superseded L83 seen in earlier Apple models, and the L83 was
> pretty much the same as L42.)
> 
> Signed-off-by: Martin Povišer <povik+lin@...ebit.org>
> Signed-off-by: James Calligeros <jcalligeros99@...il.com>
> ---
>  Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  MAINTAINERS                                                 |  1 +
>  2 files changed, 61 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/sound/cirrus,cs42l84.example.dts:25.45-46 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/sound/cirrus,cs42l84.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2
make: *** [Makefile:224: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241016-cs42l84-v1-1-8d7e9d437d2d@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.