linux-kernel - [PATCH] kernel/resource: Simplify API __devm_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241017-release_region_fix-v1-1-84a3e8441284@quicinc.com>
Date: Thu, 17 Oct 2024 23:34:49 +0800
From: Zijun Hu <zijun_hu@...oud.com>
To: Mika Westerberg <mika.westerberg@...ux.intel.com>, 
 Andrew Morton <akpm@...ux-foundation.org>, 
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
 Bjorn Helgaas <bhelgaas@...gle.com>, 
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Zijun Hu <zijun_hu@...oud.com>, linux-kernel@...r.kernel.org, 
 Zijun Hu <quic_zijuhu@...cinc.com>
Subject: [PATCH] kernel/resource: Simplify API __devm_release_region()
 implementation

From: Zijun Hu <quic_zijuhu@...cinc.com>

Simplify __devm_release_region() implementation by dedicated
API devres_release() which have below advantages than current
__release_region() + devres_destroy():

It is simpler if __devm_release_region() is undoing what
__devm_request_region() did, otherwise, it can avoid wrong and
undesired __release_region().

Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
---
linux-next tree has similar fixes as shown below:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0ee4dcafda9576910559f0471a3d6891daf9ab92
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=9bd133f05b1dca5ca4399a76d04d0f6f4d454e44
---
 kernel/resource.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index b730bd28b422..8d619c449a73 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -1673,8 +1673,7 @@ void __devm_release_region(struct device *dev, struct resource *parent,
 {
 	struct region_devres match_data = { parent, start, n };
 
-	__release_region(parent, start, n);
-	WARN_ON(devres_destroy(dev, devm_region_release, devm_region_match,
+	WARN_ON(devres_release(dev, devm_region_release, devm_region_match,
 			       &match_data));
 }
 EXPORT_SYMBOL(__devm_release_region);

---
base-commit: 9bd133f05b1dca5ca4399a76d04d0f6f4d454e44
change-id: 20241017-release_region_fix-2aa7f93367e0

Best regards,
-- 
Zijun Hu <quic_zijuhu@...cinc.com>