linux-kernel - Re: [PATCH v3 0/6] Add minimal Exynos990 SoC and SM-N981B support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1025cc1-b9e1-489b-b452-c3a729d0300e@kernel.org>
Date: Thu, 17 Oct 2024 18:37:14 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>,
 Igor Belwon <igor.belwon@...tallysanemainliners.org>
Cc: devicetree@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, Alim Akhtar <alim.akhtar@...sung.com>,
 Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v3 0/6] Add minimal Exynos990 SoC and SM-N981B support

On 17/10/2024 18:26, Rob Herring (Arm) wrote:
> 
> On Wed, 16 Oct 2024 17:47:41 +0200, Igor Belwon wrote:
>> Hi folks,
>>
>> This series adds initial support for the Exynos 990 SoC and also
>> initial board support for the Samsung Galaxy Note20 5G (SM-N981B)
>> codenamed c1s.
>>
>> The Exynos 990 SoC is also used in the S20 series, as well as in the
>> Note 20 Ultra phones. Currently the device trees added are for the
>> Exynos 990 SoC and c1s. The device tree has been tested with
>> dtbs_check W=1 and results in no warnings.
>>
>> This initial bringup consists of:
>>  * cpus
>>  * pinctrl
>>  * gpio-keys
>>  * simple-framebuffer
>>
>> This is enough to reach a shell in an initramfs. More platform support
>> will be added in the future.
>>
>> The preferred way to boot the upstream kernel is by using a shim
>> bootloader, called uniLoader [1], which works around some issues with
>> the stock, non-replacable Samsung S-LK bootloader. For example, the
>> stock bootloader leaves the decon trigger control unset, which causes
>> the framebuffer not to refresh.
>>
>> Device functionality depends on the 2nd patch series:
>> "Add Exynos990 pinctrl and chipid drivers"
>>
>> [1] https://github.com/ivoszbg/uniLoader
>>
>> Changes in v3:
>>  - Move pinctrl DT nodes from the 2nd patch series
>>  - Resend patches to the correct lists.
>>
>> Changes in v2:
>>  - Added acked-by tag by Rob Herring
>>  - Fixed two stray newlines in SoC and device DTs
>>  - Fixed commit message for the c1s device tree
>>  - Changed osc-clock to clock-osc and ordered nodes in SoC DT
>>  - Fixed ordering in the gic node in SoC DT
>>  - Fixed memory node unit address
>>  - Fixed memory node reg properties, to map all available RAM
>>  - Moved pinctrl binding commits to the 2nd patch series.
>>
>> Kind regards,
>> Igor
>>
>> Igor Belwon (6):
>>   dt-bindings: arm: cpus: Add Samsung Mongoose M5
>>   dt-bindings: hwinfo: exynos-chipid: Add compatible for Exynos 990
>>     chipid
>>   dt-bindings: arm: samsung: samsung-boards: Add bindings for Exynos 990
>>     boards
>>   soc: samsung: exynos-chipid: Add support for Exynos 990 chipid
>>   arm64: dts: exynos: Add initial support for the Exynos 990 SoC
>>   arm64: dts: exynos: Add initial support for Samsung Galaxy Note20 5G
>>     (c1s)
>>
>>  .../devicetree/bindings/arm/cpus.yaml         |    1 +
>>  .../bindings/arm/samsung/samsung-boards.yaml  |    6 +
>>  .../hwinfo/samsung,exynos-chipid.yaml         |    1 +
>>  arch/arm64/boot/dts/exynos/Makefile           |    1 +
>>  arch/arm64/boot/dts/exynos/exynos990-c1s.dts  |  115 +
>>  .../boot/dts/exynos/exynos990-pinctrl.dtsi    | 2195 +++++++++++++++++
>>  arch/arm64/boot/dts/exynos/exynos990.dtsi     |  251 ++
>>  drivers/soc/samsung/exynos-chipid.c           |    1 +
>>  8 files changed, 2571 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-c1s.dts
>>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-pinctrl.dtsi
>>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990.dtsi
>>
>> --
>> 2.45.2
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y exynos/exynos990-c1s.dtb' for 20241016154747.64343-1-igor.belwon@...tallysanemainliners.org:
> 
> arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@...inctrl@...30000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
> arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@...inctrl@...30000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
> arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@...inctrl@...40000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
> arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@...inctrl@...30000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']

These are expected, coming via different tree.

Best regards,
Krzysztof